Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10402 )
Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > Do you have a test case that shows what can break? I don't know if it breaks anything in the current state. It breaks things when I was working on IMPALA-4025. http://gerrit.cloudera.org:8080/#/c/10402/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java: http://gerrit.cloudera.org:8080/#/c/10402/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@47 PS1, Line 47: bp.getChild(0).clone(), bp.getChild(1)); > even cleaner to clone all children Done -- To view, visit http://gerrit.cloudera.org:8080/10402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41 Gerrit-Change-Number: 10402 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Tue, 15 May 2018 01:22:07 +0000 Gerrit-HasComments: Yes
