Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21755 )
Change subject: IMPALA-13287: Check overflow for bigint arithmetic ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Any notable performance impact to this? http://gerrit.cloudera.org:8080/#/c/21755/1/be/src/exprs/operators-ir.cc File be/src/exprs/operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/21755/1/be/src/exprs/operators-ir.cc@165 PS1, Line 165: #define BINARY_OP_CHECK_OVERFLOW(TYPE, TYPE_NAME) \ > Thanks! Fixed. Ack -- To view, visit http://gerrit.cloudera.org:8080/21755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf22bef737caeab241ac3c708f43c5a72bb22350 Gerrit-Change-Number: 21755 Gerrit-PatchSet: 2 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 20 Sep 2024 18:04:37 +0000 Gerrit-HasComments: Yes
