Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21755 )
Change subject: IMPALA-13287: Check overflow for bigint arithmetic ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21755/3/be/src/benchmarks/expr-benchmark.cc File be/src/benchmarks/expr-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/21755/3/be/src/benchmarks/expr-benchmark.cc@241 PS3, Line 241: // Arithmetic: Function iters/ms 10%ile 50%ile 90%ile 10%ile 50%ile 90%ile : // (relative) (relative) (relative) : // --------------------------------------------------------------------------------------------------------- : // int-add 319 323 324 1X 1X 1X : // double-add 40 40.3 40.5 0.125X 0.125X 0.125X : // : // ArithmeticCodegen: Function iters/ms 10%ile 50%ile 90%ile 10%ile 50%ile 90%ile : // (relative) (relative) (relative) : // --------------------------------------------------------------------------------------------------------- : // int-add 781 787 791 1X 1X 1X : // double-add 610 617 619 0.781X 0.784X 0.783X Thank you for adding the microbenchmark. Please update this BenchmarkArithmetic table with result from your latest run. I usually do following before running this microbenchmark to get consistent result: sudo cpupower frequency-set --governor performance echo "1" | sudo tee /sys/devices/system/cpu/intel_pstate/no_turbo Also, make sure the impala and microbenchmarking code is from RELEASE build. ./buildall.sh -skiptests -release -- To view, visit http://gerrit.cloudera.org:8080/21755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf22bef737caeab241ac3c708f43c5a72bb22350 Gerrit-Change-Number: 21755 Gerrit-PatchSet: 3 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2024 17:34:11 +0000 Gerrit-HasComments: Yes
