Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21793 )

Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21793/4/docs/impala.ditamap
File docs/impala.ditamap:

http://gerrit.cloudera.org:8080/#/c/21793/4/docs/impala.ditamap@206
PS4, Line 206:         <topicref href="topics/impala_explain_level.xml"/>
> side note: I'm not sure why this is nested under explain_level
Seems like a bug, looking how the outcome is: 
https://impala.apache.org/docs/build/plain-html/index.html
Took this out of impala_explain_level.xml


http://gerrit.cloudera.org:8080/#/c/21793/4/docs/impala.ditamap@246
PS4, Line 246:         <topicref href="topics/impala_resource_trace_ratio.xml"/>
> These are organized alphabetically. How did you decide to add it here?
My bad, I thought the generator can sort them automatically.
Put them alphabetically now.



--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Fri, 20 Sep 2024 21:59:59 +0000
Gerrit-HasComments: Yes

Reply via email to