Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc ...................................................................... IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc This patch adds documentation for AGG_MEM_CORRELATION_FACTOR and LARGE_AGG_MEM_THRESHOLD option introduced in Apache Impala 4.4.0. IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value will lower memory estimation, while lower value will result in higher memory estimation. The documentation in ImpalaService.thrift, however, says the opposite. This patch fix documentation in thrift file as well. Testing: - Run "make plain-html" in docs/ dir and confirm the output. - Manually check with comments in PlannerTest.testAggNodeMaxMemEstimate() Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90 Reviewed-on: http://gerrit.cloudera.org:8080/21793 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M common/thrift/ImpalaService.thrift M docs/impala.ditamap M docs/shared/ImpalaVariables.xml M docs/shared/impala_common.xml A docs/topics/impala_agg_mem_correlation_factor.xml A docs/topics/impala_large_agg_mem_threshold.xml 6 files changed, 161 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90 Gerrit-Change-Number: 21793 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
