Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/21683/4/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/4/be/src/util/runtime-profile.cc@2952 PS4, Line 2952: vector<vector<vector<int64_t>>> timestamps_vec; > Given the number of potential memory allocations below, it is going to be b Done. I have now used a vector copy of required values from within the 'event_sequences_map_'. http://gerrit.cloudera.org:8080/#/c/21683/4/be/src/util/runtime-profile.cc@2953 PS4, Line 2953: vector<vector<Value>> labels_vec; > Is the empty case common enough to warrant a branch? In many nodes, there are no event sequences at all. So, I believe this is necessary. Is there a way around without doing this? http://gerrit.cloudera.org:8080/#/c/21683/4/be/src/util/runtime-profile.cc@2960 PS4, Line 2960: labels_vec.resize(es_count); > Can these structures get reused? These structures are directly allocated within the JSON using RapidJSON's memory allocator('allocator'). So, it is not possible to reuse the previously allocated memory. http://gerrit.cloudera.org:8080/#/c/21683/4/be/src/util/runtime-profile.cc@2982 PS4, Line 2982: vector<int64_t> min_ts_list(BUCKET_SIZE); > Also try to re-use these vectors. Done. Now, the same previously allocated vectors have been reused. -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 25 Sep 2024 07:15:20 +0000 Gerrit-HasComments: Yes
