Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) ...................................................................... Patch Set 6: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21683/6/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/6/be/src/util/runtime-profile.cc@2966 PS6, Line 2966: labels_vec[es_idx][label_item.second] = Value(label_item.first.c_str(), allocator); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21683/6/tests/observability/test_profile_tool.py File tests/observability/test_profile_tool.py: http://gerrit.cloudera.org:8080/#/c/21683/6/tests/observability/test_profile_tool.py@76 PS6, Line 76: ) flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21683/6/tests/observability/test_profile_tool.py@79 PS6, Line 79: y flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21683/6/tests/observability/test_profile_tool.py@84 PS6, Line 84: ) flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 13:57:58 +0000 Gerrit-HasComments: Yes
