Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 )
Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/exec/iceberg-delete-node.h File be/src/exec/iceberg-delete-node.h: http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/exec/iceberg-delete-node.h@148 PS3, Line 148: * We usually take const input arguments by reference. http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/exec/iceberg-delete-node.cc File be/src/exec/iceberg-delete-node.cc: http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/exec/iceberg-delete-node.cc@294 PS3, Line 294: make_unsigned_t Why do we convert it to the unsigned counterpart if the return type is int64_t? Also, instead of std::make_unsigned_t<int64_t> we could simply use uint64_t. http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap-test.cc File be/src/util/roaring-bitmap-test.cc: http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap-test.cc@78 PS3, Line 78: ASSERT_EQ(it.GetEqualOrLarger(13), 13); Could add a comment to explain that repeating the same call is to ensure that the iterator is not moved. http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap-test.cc@89 PS3, Line 89: DenseMap Could name it "DenseMapIteration" to emphasise that this is about iteration, not dense maps in general. Similarly for SparseMap. http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap.h File be/src/util/roaring-bitmap.h: http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap.h@68 PS3, Line 68: bool HasValue() const { Could add a comment to explain what it meas to have or not have a value. -- To view, visit http://gerrit.cloudera.org:8080/21718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46487fefa300027e9df6cd7fb36c78af01dd56c1 Gerrit-Change-Number: 21718 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 08:44:53 +0000 Gerrit-HasComments: Yes
