Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 )
Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode ...................................................................... Patch Set 4: (5 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/exec/iceberg-delete-node.h File be/src/exec/iceberg-delete-node.h: http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/exec/iceberg-delete-node.h@148 PS3, Line 148: * > We usually take const input arguments by reference. We allow nullptr here. http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/exec/iceberg-delete-node.cc File be/src/exec/iceberg-delete-node.cc: http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/exec/iceberg-delete-node.cc@294 PS3, Line 294: ent_probe_row-> > Why do we convert it to the unsigned counterpart if the return type is int6 Done, and switched to uint64_t at most places. http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap-test.cc File be/src/util/roaring-bitmap-test.cc: http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap-test.cc@78 PS3, Line 78: RoaringBitmap64::Iterator it(rbm); > Could add a comment to explain that repeating the same call is to ensure th Done http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap-test.cc@89 PS3, Line 89: arger(30 > Could name it "DenseMapIteration" to emphasise that this is about iteration Done http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap.h File be/src/util/roaring-bitmap.h: http://gerrit.cloudera.org:8080/#/c/21718/3/be/src/util/roaring-bitmap.h@68 PS3, Line 68: // Returns true if the iterator currently points to a value in the bitmap. > Could add a comment to explain what it meas to have or not have a value. Done -- To view, visit http://gerrit.cloudera.org:8080/21718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46487fefa300027e9df6cd7fb36c78af01dd56c1 Gerrit-Change-Number: 21718 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 10:21:45 +0000 Gerrit-HasComments: Yes
