Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21849 )
Change subject: IMPALA-13384: Only install gcovr deps for coverage builds ...................................................................... Patch Set 3: (1 comment) Thanks a lot for fixing this, Joe; Code LGTM, just a comment request. http://gerrit.cloudera.org:8080/#/c/21849/3/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/21849/3/infra/python/bootstrap_virtualenv.py@31 PS3, Line 31: # Could you add the GCOVR step to this list? (see L#519 for the reason) -- To view, visit http://gerrit.cloudera.org:8080/21849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d0fd6d21273053aaf2acee39fcb83d9093d49a2 Gerrit-Change-Number: 21849 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 16:57:34 +0000 Gerrit-HasComments: Yes
