Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21867 )
Change subject: IMPALA-13408: use a specific flag for the topic prefix cluster identifier. ...................................................................... Patch Set 2: (2 comments) Thanks Daniel for good questions http://gerrit.cloudera.org:8080/#/c/21867/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21867/2//COMMIT_MSG@9 PS2, Line 9: IMPALA-12426 > I'm not familiar with these changes but I can't find 'cluster_id' being int There were multiple reviews under the same Jira id, I think it is https://gerrit.cloudera.org/#/c/20770/ in the file workload-management-flags.cc http://gerrit.cloudera.org:8080/#/c/21867/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/21867/2/be/src/scheduling/admission-controller.cc@82 PS2, Line 82: cluster_id > Do we have 'cluster_id' left anywhere? It still exists, defined in workload-management-flags.cc The change here is because the usages are subtly different so I want to tease them apart. -- To view, visit http://gerrit.cloudera.org:8080/21867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd3f7e1c73c00a7aaeee79ecb461209e3939c422 Gerrit-Change-Number: 21867 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2024 16:16:52 +0000 Gerrit-HasComments: Yes
