Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21867 )
Change subject: IMPALA-13408: use a specific flag for the topic prefix cluster identifier. ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/21867/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21867/2//COMMIT_MSG@16 PS2, Line 16: An important difference is that the query_log cluster_id must be set > I guess I don't understand how "cluster_id must be set only on coordinators There is nothing stopping any arbitrary flag from being set on any daemon. If that particular daemon does not use a flag, then it is ignored. The issue we are trying to prevent is a split brain problem when cluster_id does not get specified everywhere. It's a difficult situation to detect and diagnose. Another potential issue is the users specifying the same cluster_id across multiple clusters which would result in cross-communication between two clusters. TL;DR -- 'cluster_id' flag is meaningful to humans while 'cluster_membership_topic_id' flag is meaningful to cluster coordination. http://gerrit.cloudera.org:8080/#/c/21867/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/21867/2/be/src/scheduling/admission-controller.cc@82 PS2, Line 82: cluster_id > It still exists, defined in workload-management-flags.cc 'cluster_id' flag is meaningful to humans and used in workload management while 'cluster_membership_topic_id' flag is meaningful to cluster coordination. -- To view, visit http://gerrit.cloudera.org:8080/21867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd3f7e1c73c00a7aaeee79ecb461209e3939c422 Gerrit-Change-Number: 21867 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 02 Oct 2024 22:20:36 +0000 Gerrit-HasComments: Yes
