Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 8: Here is a report for this change: https://jenkins.impala.io/view/all/job/calcite-report-prototype/11/artifact/Impala/calcite_report/html/index.html To keep it from crashing, I needed the same change as the previous patch to make https://github.com/apache/impala/blob/master/be/src/exec/analytic-eval-node.cc#L69 return status. I also needed to turn off TestIceberg in query_test/test_scanners.py: https://github.com/apache/impala/blob/master/tests/query_test/test_scanners.py#L508 I also added a skip for this test case that constructs a huge SQL and expects the planner to bail out: https://github.com/apache/impala/blob/master/tests/query_test/test_exprs.py#L103 Calcite doesn't bail out, so it probably takes a crazy amount of time to compile (I stopped it locally after 10 minutes). I also didn't run query_test/test_join_queries.py as that crashes at this assert: https://github.com/apache/impala/blob/master/be/src/runtime/descriptors.cc#L483 To be clear, this is all good, because a lot more statements are running and a lot more are passing. -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2024 16:46:10 +0000 Gerrit-HasComments: No
