Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/21575/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21575/7//COMMIT_MSG@45 PS7, Line 45: - Created bypass for some extract time operators to use nit: extra space in "time operators" http://gerrit.cloudera.org:8080/#/c/21575/7//COMMIT_MSG@64 PS7, Line 64: - Added the MinusToDistinct rules. These ruleis exist in Calcite and typo: rules Actually this whole sentence doesn't read well. http://gerrit.cloudera.org:8080/#/c/21575/7/java/calcite-planner/pom.xml File java/calcite-planner/pom.xml: http://gerrit.cloudera.org:8080/#/c/21575/7/java/calcite-planner/pom.xml@55 PS7, Line 55: <scope>provided</scope> Where is this provided from? http://gerrit.cloudera.org:8080/#/c/21575/7/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/21575/7/java/calcite-planner/src/main/codegen/templates/Parser.jj@4708 PS7, Line 4708: <QUOTED_IDENTIFIER> { How does this differ from BIG_QUERY_DOUBLE_QUOTED_STRING? http://gerrit.cloudera.org:8080/#/c/21575/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/21575/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@85 PS7, Line 85: .build(); nit: extra whitespace http://gerrit.cloudera.org:8080/#/c/21575/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java: http://gerrit.cloudera.org:8080/#/c/21575/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java@18 PS8, Line 18: package org.apache.calcite.rel.rules; Should this really be in this package? Doesn't match the file path. -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 04 Oct 2024 16:13:05 +0000 Gerrit-HasComments: Yes
