Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21860 )
Change subject: IMPALA-13405: Do tuple analysis to lower AggregationNode cardinality ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21860/4/testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test File testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test: http://gerrit.cloudera.org:8080/#/c/21860/4/testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test@384 PS4, Line 384: | row-size=40B cardinality=3.00M > Thanks for noticing this. I think this is bug on my code for not noticing N The real reason for this misestimation is because o_orderkey, o_orderdate, o_shippriority are nested under array column c_orders. Query: describe customer c_custkey bigint c_name string c_address string c_nationkey smallint c_phone string c_acctbal decimal(12,2) c_mktsegment string c_comment string c_orders "array<struct< o_orderkey:bigint, o_orderstatus:string, o_totalprice:decimal(12,2), o_orderdate:string, o_orderpriority:string, o_clerk:string, o_shippriority:int, o_comment:string, o_lineitems:array<struct< l_partkey:bigint, l_suppkey:bigint, l_linenumber:int, l_quantity:decimal(12,2), l_extendedprice:decimal(12,2), l_discount:decimal(12,2), l_tax:decimal(12,2), l_returnflag:string, l_linestatus:string, l_shipdate:string, l_commitdate:string, l_receiptdate:string, l_shipinstruct:string, l_shipmode:string, l_comment:string >> >>" I decide to skip such SlotRef in ps5. -- To view, visit http://gerrit.cloudera.org:8080/21860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd589ab5f7ba9566a0d35784f61f5ffaef5696e7 Gerrit-Change-Number: 21860 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2024 19:53:54 +0000 Gerrit-HasComments: Yes
