Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21860 )
Change subject: IMPALA-13405: Do tuple analysis to lower AggregationNode cardinality ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/21860/6/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/21860/6/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@270 PS6, Line 270: LOG.trace(getDisplayLabel() + " aggPhase=" + aggPhase_ nit: could we switch this to use slf4j format strings? http://gerrit.cloudera.org:8080/#/c/21860/6/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@328 PS6, Line 328: LOG.info("Slot " + slotRef.debugString() + " match with tuple " + tupleId); Why info after checking isTraceEnabled? -- To view, visit http://gerrit.cloudera.org:8080/21860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd589ab5f7ba9566a0d35784f61f5ffaef5696e7 Gerrit-Change-Number: 21860 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2024 20:42:29 +0000 Gerrit-HasComments: Yes
