Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21882 )
Change subject: IMPALA-12967, IMPALA-13059, IMPALA-13144, IMPALA-13195: test_migrated_table_field_id_resolution fails in exhaustive mode ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21882/2/tests/util/iceberg_metadata_util.py File tests/util/iceberg_metadata_util.py: http://gerrit.cloudera.org:8080/#/c/21882/2/tests/util/iceberg_metadata_util.py@54 PS2, Line 54: prefix, unique_database, table_name optional: the code could be a bit less noisy by moving these to a single argument (e.g. table_params=(prefix, unique_database, table_name)) and unpacking this only in generate_new_path http://gerrit.cloudera.org:8080/#/c/21882/2/tests/util/iceberg_metadata_util.py@117 PS2, Line 117: li = s.rsplit(old_expr, maxsplit) the table name should be always there, right? this could be checked by asserting that the length of li is 2 -- To view, visit http://gerrit.cloudera.org:8080/21882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id41a78940a5da5344735974e1d2c94ed4f24539a Gerrit-Change-Number: 21882 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 14 Oct 2024 15:58:27 +0000 Gerrit-HasComments: Yes
