Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21882 )

Change subject: IMPALA-12967, IMPALA-13059, IMPALA-13144, IMPALA-13195: 
test_migrated_table_field_id_resolution fails in exhaustive mode
......................................................................


Patch Set 3:

(2 comments)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/21882/2/tests/util/iceberg_metadata_util.py
File tests/util/iceberg_metadata_util.py:

http://gerrit.cloudera.org:8080/#/c/21882/2/tests/util/iceberg_metadata_util.py@54
PS2, Line 54:
> optional: the code could be a bit less noisy by moving these to a single ar
Done


http://gerrit.cloudera.org:8080/#/c/21882/2/tests/util/iceberg_metadata_util.py@117
PS2, Line 117:     maxsplit = 1
> the table name should be always there, right? this could be checked by asse
Done



--
To view, visit http://gerrit.cloudera.org:8080/21882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id41a78940a5da5344735974e1d2c94ed4f24539a
Gerrit-Change-Number: 21882
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 15 Oct 2024 14:22:20 +0000
Gerrit-HasComments: Yes

Reply via email to