Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21925 )
Change subject: IMPALA-11298: Allow users to share hs2 sessions from multiple hosts ...................................................................... Patch Set 2: (3 comments) I think code is good, I am just quibbling about comments and explanations http://gerrit.cloudera.org:8080/#/c/21925/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21925/2//COMMIT_MSG@9 PS2, Line 9: hs2 sessions are not necessarily bound to a host but to a user. This > I think this is mainly a clarification. hs2 sessions are associated with a Maybe some of this could be put in the commit message? The hue example is the reason for doing this IIUIC. http://gerrit.cloudera.org:8080/#/c/21925/2/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/21925/2/be/src/service/impala-hs2-server.cc@371 PS2, Line 371: state->connected_user_short = > Yeah that's correct this is mainly to cache the short user name in session' I think what I'm hoping for is a comment saying something like "Call GetShortUsernameFromKerberosPrincipal even though we don't know that state->connected_user is a Kerberos principal". http://gerrit.cloudera.org:8080/#/c/21925/2/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21925/2/be/src/service/impala-server.h@1400 PS2, Line 1400: const string connected_user_short = : ThriftServer::GetThreadConnectionContext()->kerberos_user_short; : const string session_user_short = session_->connected_user_short; > 'connected_user_short' is the user which is currently connected to this ses I suppose this makes sense. Maybe rename 'connected_user_short' to connection_user_short to make it clear it is similar to connection_username. -- To view, visit http://gerrit.cloudera.org:8080/21925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c539cda8c760c8667a2e8cbb6d5c7902888de9 Gerrit-Change-Number: 21925 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 00:35:18 +0000 Gerrit-HasComments: Yes
