Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21925 )
Change subject: IMPALA-11298: Allow proxy users to share hs2 session from different hosts or realms ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21925/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21925/3//COMMIT_MSG@9 PS3, Line 9: Some proxy clients like Hue could reuse hs2 session across mul > For query profiles, one option could be to log both 'Connected User:' and ' Can you mention "Connected User:" + FunctionContext::user() as a side effects? I don't think that it is a big issue, but can be a bit confusing for someone who bumps into this. It could be cleaned up later in the documentation that this contains the proxy user that started the session, not the one that started the query. http://gerrit.cloudera.org:8080/#/c/21925/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21925/4//COMMIT_MSG@13 PS4, Line 13: probably okay ImpalaServer::AuthorizeProxyUser() could referred here, as it only uses the short user name part, so the rest doesn't matter. -- To view, visit http://gerrit.cloudera.org:8080/21925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c539cda8c760c8667a2e8cbb6d5c7902888de9 Gerrit-Change-Number: 21925 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 17:31:16 +0000 Gerrit-HasComments: Yes
