Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21663 )
Change subject: IMPALA-13126: ReloadEvent.isOlderEvent() should hold table read lock ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21663/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21663/1//COMMIT_MSG@13 PS1, Line 13: DDLs/DMLs modifying the partition list. Can we add a stress test to reproduce the issue? http://gerrit.cloudera.org:8080/#/c/21663/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21663/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1299 PS1, Line 1299: isPartitionLoadedAfterEvent isPartitionLoadedAfterEvent() is also used here. Should we acquire the table read lock here, or acquire the lock inside the method to be simple? -- To view, visit http://gerrit.cloudera.org:8080/21663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26933f98556736f66df986f9440ebb64be395bc1 Gerrit-Change-Number: 21663 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 01:43:46 +0000 Gerrit-HasComments: Yes
