Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21701 )
Change subject: IMPALA-12957: Support reading Inf and NaN from JSON ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21701/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21701/1//COMMIT_MSG@19 PS1, Line 19: https://github.com/Tencent/rapidjson/issues/2299 I see this is resolved. Do you know if rapidjson will have a new release to contain this? We are currently using rapidjson-1.1.0 which is released in 2016 (but still the latest version).. If no new releases, we can bump our rapidjson version in native-toolchain to add that fix. Just like what we did for the ORC lib: https://github.com/cloudera/native-toolchain/tree/810d0f47572d9ac4036c34eb2ad6342d51d510cd/source/orc/orc-1.7.9-patches -- To view, visit http://gerrit.cloudera.org:8080/21701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05ee7c7c7fb7e78fff9570f659ce2d13c94a4e10 Gerrit-Change-Number: 21701 Gerrit-PatchSet: 1 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 02:16:47 +0000 Gerrit-HasComments: Yes
