Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 )
Change subject: IMPALA-13333: Limit memory estimation if PlanNode can spill ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/21762/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21762/10//COMMIT_MSG@32 PS10, Line 32: r > Nit: isn't it "Controller"? Done http://gerrit.cloudera.org:8080/#/c/21762/10/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/21762/10/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1413 PS10, Line 1413: ng to disk into account [when calc > This would suggest to me that "memScale > 0.5". Maybe we could say "... 'qu Done http://gerrit.cloudera.org:8080/#/c/21762/10/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java File fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java: http://gerrit.cloudera.org:8080/#/c/21762/10/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java@114 PS10, Line 114: "minMemReservationBytes (%s) is greater than maxMemReservationBytes (%s)!", > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/21762/10/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java@117 PS10, Line 117: "memEstimateBytes (%s) is greater than maxMemReservationBytes (%s)!", > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 16 Oct 2024 14:53:22 +0000 Gerrit-HasComments: Yes
