Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 )
Change subject: IMPALA-13333: Limit memory estimation if PlanNode can spill ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/21762/12/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java File fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java: http://gerrit.cloudera.org:8080/#/c/21762/12/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java@736 PS12, Line 736: @Test : public void testSortNodeMemLimitExecutors() { : // Test that MEM_LIMIT_EXECUTORS & MEM_LIMIT_COORDINATORS (20GB) override : // impala.admission-control.max-query-mem-limit.root.large (50GB) for SortNode. : TQueryOptions optsWithLimit = new TQueryOptions(options); : optsWithLimit.setMem_limit_executors(20L * ByteUnits.GIGABYTE); : optsWithLimit.setMem_limit_coordinators(20 * ByteUnits.GIGABYTE); : runPlannerTestFile("tpcds_cpu_cost/tpcds-q31-mem_limit_executors-20g", testDb, : optsWithLimit, testOptions); : } : : @Test : public void testSortNodeMemLimit() { : // Test that MEM_LIMIT (10GB) override MEM_LIMIT_EXECUTORS/MEM_LIMIT_COORDINATORS : // (20GB) and impala.admission-control.max-query-mem-limit.root.large (50GB) for : // SortNode. : TQueryOptions optsWithLimit = new TQueryOptions(options); : optsWithLimit.setMem_limit_executors(20 * ByteUnits.GIGABYTE); : optsWithLimit.setMem_limit_coordinators(20 * ByteUnits.GIGABYTE); : optsWithLimit.setMem_limit(10 * ByteUnits.GIGABYTE); : runPlannerTestFile( : "tpcds_cpu_cost/tpcds-q31-mem_limit-10g", testDb, optsWithLimit, testOptions); : } > Find different testcase because Q31 plan has been improved by IMPALA-13086. Replace with Q64 http://gerrit.cloudera.org:8080/#/c/21762/12/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java@784 PS12, Line 784: @Test : public void testHashJoinNodeMemLimitExecutors() { : // Test that MEM_LIMIT_EXECUTORS & MEM_LIMIT_COORDINATORS (20GB) override : // impala.admission-control.max-query-mem-limit.root.large (50GB) for HashJoinNode. : TQueryOptions optsWithLimit = new TQueryOptions(options); : optsWithLimit.setMem_limit_executors(20 * ByteUnits.GIGABYTE); : optsWithLimit.setMem_limit_coordinators(20 * ByteUnits.GIGABYTE); : runPlannerTestFile("tpcds_cpu_cost/tpcds-q04-mem_limit_executors-20g", testDb, : optsWithLimit, testOptions); : } : : @Test : public void testHashJoinNodeMemLimit() { : // Test that MEM_LIMIT (10GB) override MEM_LIMIT_EXECUTORS/MEM_LIMIT_COORDINATORS : // (20GB) and impala.admission-control.max-query-mem-limit.root.large (50GB) for : // HashJoinNode. : TQueryOptions optsWithLimit = new TQueryOptions(options); : optsWithLimit.setMem_limit_executors(20 * ByteUnits.GIGABYTE); : optsWithLimit.setMem_limit_coordinators(20 * ByteUnits.GIGABYTE); : optsWithLimit.setMem_limit(10 * ByteUnits.GIGABYTE); : runPlannerTestFile( : "tpcds_cpu_cost/tpcds-q04-mem_limit-10g", testDb, optsWithLimit, testOptions); : } > Find different testcase because Q4 plan has been improved by IMPALA-13086. Replace with Q97 -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 12 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2024 21:36:30 +0000 Gerrit-HasComments: Yes
