Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21942
Change subject: IMPALA-13456: Calcite planner: fix issues with quotes ...................................................................... IMPALA-13456: Calcite planner: fix issues with quotes Changed the parser to use quotes that are inline with how Impala treats quotes, including allowing single quotes, double quotes, and back ticks for aliases, and also allowing the backslash to be used as an escape character. This is inline with what BigQuery uses in Calcite. A couple of unit tests were added, but these will be tested more extensively by the ParserTest frontend unit test when that gets committed. Also, added the VALUE as a nonreserved keyword which is used in the tpcds queries (along with the doublequotes) Change-Id: I67ebb19912714c240b99a42d9f2f02f78c189350 --- M java/calcite-planner/src/main/codegen/config.fmpp M java/calcite-planner/src/main/codegen/templates/Parser.jj M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteQueryParser.java M testdata/workloads/functional-query/queries/QueryTest/calcite.test 4 files changed, 45 insertions(+), 20 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/21942/1 -- To view, visit http://gerrit.cloudera.org:8080/21942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I67ebb19912714c240b99a42d9f2f02f78c189350 Gerrit-Change-Number: 21942 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]>
