Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21942 )
Change subject: IMPALA-13456: Calcite planner: fix issues with quotes ...................................................................... IMPALA-13456: Calcite planner: fix issues with quotes Changed the parser to use quotes that are inline with how Impala treats quotes, including allowing single quotes, double quotes, and back ticks for aliases, and also allowing the backslash to be used as an escape character. This is inline with what BigQuery uses in Calcite. A couple of unit tests were added, but these will be tested more extensively by the ParserTest frontend unit test when that gets committed. Also, added the VALUE as a nonreserved keyword which is used in the tpcds queries (along with the doublequotes) Change-Id: I67ebb19912714c240b99a42d9f2f02f78c189350 Reviewed-on: http://gerrit.cloudera.org:8080/21942 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M java/calcite-planner/src/main/codegen/config.fmpp M java/calcite-planner/src/main/codegen/templates/Parser.jj M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteQueryParser.java M testdata/workloads/functional-query/queries/QueryTest/calcite.test 4 files changed, 45 insertions(+), 20 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I67ebb19912714c240b99a42d9f2f02f78c189350 Gerrit-Change-Number: 21942 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
