Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21864 )
Change subject: IMPALA-13340: Fix missing partitions in COPY TESTCASE of LocalCatalog mode ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21864/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21864/2//COMMIT_MSG@15 PS2, Line 15: to Nit: remove word http://gerrit.cloudera.org:8080/#/c/21864/2//COMMIT_MSG@46 PS2, Line 46: unpartitiond Nit: unpartitioned http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/Table.java@610 PS2, Line 610: <> Nit: was the removal of TColumn needed? If not, I favor leaving this line unchanged even though the empty angle brackets <> is newer syntax. http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1109 PS2, Line 1109: %s", part) Was this a temporary debugging change or is it needed? http://gerrit.cloudera.org:8080/#/c/21864/2/tests/metadata/test_testcase_builder.py File tests/metadata/test_testcase_builder.py: http://gerrit.cloudera.org:8080/#/c/21864/2/tests/metadata/test_testcase_builder.py@70 PS2, Line 70: assert len(res.data) == 24 Is there any way to assert the partition ids changed? Possibly by exporting the table again and checking partition ids? -- To view, visit http://gerrit.cloudera.org:8080/21864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc2e8b71564ad37973ddfca92801afea8e26ff73 Gerrit-Change-Number: 21864 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 16 Oct 2024 22:24:27 +0000 Gerrit-HasComments: Yes
