Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21864 )
Change subject: IMPALA-13340: Fix missing partitions in COPY TESTCASE of LocalCatalog mode ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/21864/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21864/2//COMMIT_MSG@15 PS2, Line 15: se > Nit: remove word Done http://gerrit.cloudera.org:8080/#/c/21864/2//COMMIT_MSG@46 PS2, Line 46: unpartitione > Nit: unpartitioned Done http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/Table.java@610 PS2, Line 610: <T > Nit: was the removal of TColumn needed? If not, I favor leaving this line Done http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1109 PS2, Line 1109: %s", part) > Was this a temporary debugging change or is it needed? This is helpful to print what the partition in the response looks like. So we can know what's missing in it. http://gerrit.cloudera.org:8080/#/c/21864/2/tests/metadata/test_testcase_builder.py File tests/metadata/test_testcase_builder.py: http://gerrit.cloudera.org:8080/#/c/21864/2/tests/metadata/test_testcase_builder.py@70 PS2, Line 70: {"PLANNER_TESTCASE_MODE": True}) > Is there any way to assert the partition ids changed? Possibly by exporting Partition ids are not exposed to the clients. But we can get it from the "/catalog_object" endpoint of catalogd. Added a check to verify the partition ids changed. http://gerrit.cloudera.org:8080/#/c/21864/3/tests/metadata/test_testcase_builder.py File tests/metadata/test_testcase_builder.py: http://gerrit.cloudera.org:8080/#/c/21864/3/tests/metadata/test_testcase_builder.py@19 PS3, Line 19: from tests.common.impala_test_suite import ImpalaTestSuite > flake8: F401 'tests.common.impala_cluster.ImpalaCluster' imported but unuse Done -- To view, visit http://gerrit.cloudera.org:8080/21864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc2e8b71564ad37973ddfca92801afea8e26ff73 Gerrit-Change-Number: 21864 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 18 Oct 2024 12:27:39 +0000 Gerrit-HasComments: Yes
