Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21940 )

Change subject: IMPALA-12554: Create one Ranger policy for multi-column GRANT
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21940/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
File 
fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java:

http://gerrit.cloudera.org:8080/#/c/21940/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@498
PS1, Line 498: the fields other than database, table, and
             :    * column names are the same.
Is it actually possible for a single call to contain multiple databases/tables? 
This seems to be an untested case.



--
To view, visit http://gerrit.cloudera.org:8080/21940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0ebba256c7135b4b0d2160856202292d720c6d
Gerrit-Change-Number: 21940
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 17 Oct 2024 09:39:13 +0000
Gerrit-HasComments: Yes

Reply via email to