Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21940 )
Change subject: IMPALA-12554: Create one Ranger policy for multi-column GRANT ...................................................................... Patch Set 1: (1 comment) I only had a very vague look, I added a comment. http://gerrit.cloudera.org:8080/#/c/21940/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/21940/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@327 PS1, Line 327: LOG.debug("Granting privilege(s) took {} ms", This wording suggests that privileges were indeed granted, but we may arrive here from the CATCH branch too. Maybe something like "Handling privilege request took ..." or "Handling grant privilege request took ..." would be better. Similarly for revokePrivilege(). -- To view, visit http://gerrit.cloudera.org:8080/21940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b0ebba256c7135b4b0d2160856202292d720c6d Gerrit-Change-Number: 21940 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 17 Oct 2024 15:03:07 +0000 Gerrit-HasComments: Yes
