Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21941 )
Change subject: IMPALA-13461: Added rules to make tpcds queries work. ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21941/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21941/4//COMMIT_MSG@18 PS4, Line 18: The CalciteRelNodeConverter handles breaks down a SubQuery RelNode nit: handles breaking down http://gerrit.cloudera.org:8080/#/c/21941/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java: http://gerrit.cloudera.org:8080/#/c/21941/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java@214 PS4, Line 214: default ImpalaMinusToDistinctRule.Config withOperandFor( nit: this is unused after you rewrote initializing DEFAULT. -- To view, visit http://gerrit.cloudera.org:8080/21941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03a38aaa5c413b9b4d2f4c179de07935b672a031 Gerrit-Change-Number: 21941 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 18 Oct 2024 22:55:07 +0000 Gerrit-HasComments: Yes
