Anonymous Coward (816) has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21941 )

Change subject: IMPALA-13461: Added rules to make tpcds queries work.
......................................................................


Patch Set 5:

Hi, in ImpalaAnalyticRel.java getPlanNode(), i see
PlanNode planNode = analyticPlanner.createSingleNodePlan(
        inputNodeWithExprs.planNode_, Collections.emptyList(), new 
ArrayList<>());

do a lot of very nice optimizations, will you code thoes optimizations to 
calcite rules in future?

This way we do not need analyticPlanner any more.


--
To view, visit http://gerrit.cloudera.org:8080/21941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a38aaa5c413b9b4d2f4c179de07935b672a031
Gerrit-Change-Number: 21941
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Anonymous Coward (816)
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Mon, 21 Oct 2024 03:48:50 +0000
Gerrit-HasComments: No

Reply via email to