Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10349 )
Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() ...................................................................... IMPALA-6995: avoid DCHECK in TimestampParse::Parse() The bug was that the string's length is checked before trimming leading and trailing spaces instead of afterwards. The bug has been present for a long time but couldn't hit a DCHECK until recently. Testing: Added some backend tests that reproduce the crash. Change-Id: I02a18ffd8893fe74f5830144300f745ce31477b1 Reviewed-on: http://gerrit.cloudera.org:8080/10349 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exprs/expr-test.cc M be/src/runtime/timestamp-parse-util.cc 2 files changed, 56 insertions(+), 51 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I02a18ffd8893fe74f5830144300f745ce31477b1 Gerrit-Change-Number: 10349 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
