Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21805 )
Change subject: [WIP] IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21805/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/21805/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@798 PS1, Line 798: BackendConfig.INSTANCE != null > Did this happen for Java based frontend unit-test? Yes. Working to figure out how to address it. The java/ module unit tests are not regularly run as far as I can see, and don't have the right environment setup to load libfesupport or use other frontend helpers. http://gerrit.cloudera.org:8080/#/c/21805/1/java/jamm-prefix/src/jamm File java/jamm-prefix/src/jamm: http://gerrit.cloudera.org:8080/#/c/21805/1/java/jamm-prefix/src/jamm@1 PS1, Line 1: Subproject commit 49c3e691c43a39ddaccaf19839ef316807009377 > why do you need to add this file? Agreed, this shouldn't be present. -- To view, visit http://gerrit.cloudera.org:8080/21805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127 Gerrit-Change-Number: 21805 Gerrit-PatchSet: 2 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 22 Oct 2024 23:42:56 +0000 Gerrit-HasComments: Yes
