Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21805 )
Change subject: [WIP] IMPALA-12789: Fix unit-test code JdbcDataSourceTest.java ...................................................................... Patch Set 4: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21805/4/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java File fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java: http://gerrit.cloudera.org:8080/#/c/21805/4/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java@80 PS4, Line 80: + "\"driver.url\":\"hdfs://localhost:20500/test-warehouse/data-sources/jdbc-drivers/postgresql-jdbc.jar\", " line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/21805/4/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java@91 PS4, Line 91: private static List<List<TBinaryPredicate>> acceptedPredicates_ = Lists.newArrayList(); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21805/4/fe/src/test/java/org/apache/impala/extdatasource/jdbc/JdbcDataSourceTest.java@116 PS4, Line 116: LOG.info("setup predicates:{}, expectReturnRows: {}", predicates_, expectReturnRows_); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21805/4/testdata/bin/load-ext-data-sources.sh File testdata/bin/load-ext-data-sources.sh: http://gerrit.cloudera.org:8080/#/c/21805/4/testdata/bin/load-ext-data-sources.sh@101 PS4, Line 101: INSERT INTO test_strategy (strategy_id, name, referrer, landing, priority, implementation, last_modified) line too long (105 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie07173d256d73c88f5a6c041f087db16b6ff3127 Gerrit-Change-Number: 21805 Gerrit-PatchSet: 4 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 30 Nov 2024 16:43:17 +0000 Gerrit-HasComments: Yes
