Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 )
Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query ...................................................................... Patch Set 1: (5 comments) just a few more cleanup asks http://gerrit.cloudera.org:8080/#/c/10415/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10415/1/be/src/service/impala-server.cc@1015 PS1, Line 1015: now + (1000L) maybe have a named constant for this or a default constructor specifically for resource expiration events with a comment that resources checks are done every second. http://gerrit.cloudera.org:8080/#/c/10415/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/10415/1/common/thrift/ImpalaInternalService.thrift@286 PS1, Line 286: Scan bytes limit, after which a query will be cancelled nit: "See comment in ImpalaService.thrift." would work too http://gerrit.cloudera.org:8080/#/c/10415/1/common/thrift/ImpalaInternalService.thrift@289 PS1, Line 289: CPU time limit in seconds, after which a query will be cancelled same here http://gerrit.cloudera.org:8080/#/c/10415/1/tests/custom_cluster/test_query_expiration.py File tests/custom_cluster/test_query_expiration.py: http://gerrit.cloudera.org:8080/#/c/10415/1/tests/custom_cluster/test_query_expiration.py@179 PS1, Line 179: client.execute("SET MAX_CPU_TIME_S=10000") : client.execute("SET MAX_SCAN_BYTES=10G") can use this instead to set multiple options: set_configuration(self, config_option_dict) http://gerrit.cloudera.org:8080/#/c/10415/1/tests/custom_cluster/test_query_expiration.py@182 PS1, Line 182: client.execute("SET MAX_CPU_TIME_S=0") : client.execute("SET MAX_SCAN_BYTES=0") similarly can use this instead: clear_configuration() -- To view, visit http://gerrit.cloudera.org:8080/10415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 1 Gerrit-Owner: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 16 May 2018 21:07:40 +0000 Gerrit-HasComments: Yes
