Hello Tim Armstrong, Bikramjeet Vig,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10415
to look at the new patch set (#4).
Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query
......................................................................
IMPALA-6034: Add Cpu and scanned bytes limits per query
To protect Impala from runaway queries add per query limits for Cpu and
scanned bytes, limits are enforced via query options and applied to the entire
query, not per backend like mem_limit.
If a query exceeds any of the limits it will get cancelled.
Query profile is updated to include query wide and per backend metrics for Cpu
and scanned bytes.
Testing:
Added tests for various permutations for MAX_CPU_TIME_S and MAX_SCAN_BYTES
Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
A
testdata/workloads/functional-query/queries/QueryTest/query-resource-limits.test
A tests/query_test/test_query_resource_limits.py
13 files changed, 376 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/10415/4
--
To view, visit http://gerrit.cloudera.org:8080/10415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20
Gerrit-Change-Number: 10415
Gerrit-PatchSet: 4
Gerrit-Owner: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
