Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 58: (3 comments) http://gerrit.cloudera.org:8080/#/c/21142/58/be/src/catalog/workload-management-init.cc File be/src/catalog/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21142/58/be/src/catalog/workload-management-init.cc@524 PS58, Line 524: Status ip_status = HostnameToIpAddr(FLAGS_hostname, &ip_addr); Looks like FLAGS_hostname can be empty. Can you check the implication from this documentation and default values? // This will be defaulted to the host name returned by the OS. // This name is used in the principal generated for Kerberos authorization. DEFINE_string(hostname, "", "Hostname to use for this daemon, also used as part of " "the Kerberos principal, if enabled. If not set, the system default will be" " used"); DEFINE_bool(use_resolved_hostname, false, "If true, --hostname is resolved before use, " "so that the IP address will be used everywhere instead of the hostname."); See also related code in init.cc http://gerrit.cloudera.org:8080/#/c/21142/56/be/src/workload_mgmt/workload-management-fields-test.cc File be/src/workload_mgmt/workload-management-fields-test.cc: http://gerrit.cloudera.org:8080/#/c/21142/56/be/src/workload_mgmt/workload-management-fields-test.cc@103 PS56, Line 103: : vector<FieldDefEntry> expected_field_defs = { : _createV100String(TQueryTableColumn::CLUSTER_ID), : _cr > The reason I went with incrementing an iterator is that the [] operator on Done http://gerrit.cloudera.org:8080/#/c/21142/58/be/src/workload_mgmt/workload-management-fields-test.cc File be/src/workload_mgmt/workload-management-fields-test.cc: http://gerrit.cloudera.org:8080/#/c/21142/58/be/src/workload_mgmt/workload-management-fields-test.cc@163 PS58, Line 163: int i=0; nit: missing space around operator. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 58 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2024 03:24:13 +0000 Gerrit-HasComments: Yes
