Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 61: (2 comments) http://gerrit.cloudera.org:8080/#/c/21142/56/be/src/workload_mgmt/workload-management-fields-test.cc File be/src/workload_mgmt/workload-management-fields-test.cc: http://gerrit.cloudera.org:8080/#/c/21142/56/be/src/workload_mgmt/workload-management-fields-test.cc@103 PS56, Line 103: : vector<FieldDefEntry> expected_field_defs = { : _createV100String(TQueryTableColumn::CLUSTER_ID), : _ > Done Eventually we'll have zip_view, but not on C++23 yet. Could use https://www.boost.org/doc/libs/1_56_0/libs/range/doc/html/range/reference/utilities/combine.html if you want to get fancy. for (const auto& it : boost::combine(expected_field_defs, FIELD_DEFINITIONS)) { EXPECT_PRED2(_fieldDefsEqual, it.get<0>(), it.get<1>()); } might do it. http://gerrit.cloudera.org:8080/#/c/21142/56/be/src/workload_mgmt/workload-management-test.cc File be/src/workload_mgmt/workload-management-test.cc: http://gerrit.cloudera.org:8080/#/c/21142/56/be/src/workload_mgmt/workload-management-test.cc@26 PS56, Line 26: #include "kudu/util/version_util.h" > I agree it's strange. It's also an anti-pattern to unit test private/inter It's still including a .cc file to access internal state. I think it's reasonable to have a read-only way to see the requested schema version, so I still prefer restoring GetTargetSchemaVersion. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 61 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 28 Oct 2024 18:53:38 +0000 Gerrit-HasComments: Yes
