Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21142 )

Change subject: IMPALA-12737: Query columns in workload management tables.
......................................................................


Patch Set 62:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21142/62/be/src/workload_mgmt/workload-management.cc
File be/src/workload_mgmt/workload-management.cc:

http://gerrit.cloudera.org:8080/#/c/21142/62/be/src/workload_mgmt/workload-management.cc@181
PS62, Line 181: /// associated mutex.
> Associated mutex no longer exists. Let's instead say it should not be modif
I think we might need to make this atomic. StartupChecks happens on the worker 
thread, and I think queries can be executed before StartupChecks has finished.



--
To view, visit http://gerrit.cloudera.org:8080/21142
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7
Gerrit-Change-Number: 21142
Gerrit-PatchSet: 62
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Mon, 28 Oct 2024 23:00:07 +0000
Gerrit-HasComments: Yes

Reply via email to