Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21989
Change subject: IMPALA-13495: Make exceptions from the Calcite planner easiser to classify ...................................................................... IMPALA-13495: Make exceptions from the Calcite planner easiser to classify This makes several changes to the Calcite planner to improve the generated exceptions when there are errors: 1. When the Calcite parser produces SqlParseException, this is converted to Impala's regular ParseException. 2. When the Calcite validation fails, it produces a CalciteContextException, which is a wrapper around the real cause. This converts these validation errors into AnalysisExceptions. 3. This produces UnsupportedFeatureException for non-HDFS table types like Kudu, HBase, Iceberg, and views. 4. This changes exception handling in CalciteJniFrontend.java so it does not convert exceptions to InternalException. The JNI code will print the stacktrace for exceptions, so this drops the existing call to print the exception stack trace. Testing: - Ran some end-to-end tests with a mode that continues past failures and examined the output. Change-Id: I6702ceac1d1d67c3d82ec357d938f12a6cf1c828 --- M fe/src/main/java/org/apache/impala/analysis/Parser.java A fe/src/main/java/org/apache/impala/common/ParseException.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteQueryParser.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteValidator.java 6 files changed, 70 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/21989/1 -- To view, visit http://gerrit.cloudera.org:8080/21989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6702ceac1d1d67c3d82ec357d938f12a6cf1c828 Gerrit-Change-Number: 21989 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]>
