Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21923 )
Change subject: IMPALA-13441: Support explain statements in Impala planner ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21923/4/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/21923/4/java/calcite-planner/src/main/codegen/templates/Parser.jj@1134 PS4, Line 1134: ( > Can we add a comment about other methods that are left in that we might wan Heh, I made a reply in the other commit that I wanted to keep this around and just comment it out. Do you prefer to remove this or comment it out? Might be too cluttered if I comment it out here. I can put in a comment either way. http://gerrit.cloudera.org:8080/#/c/21923/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/21923/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@149 PS4, Line 149: if (Parser.parse(queryCtx.getStmt()) instanceof SelectStmt) { > What if this throws an exception? It didn't flag any coding issues, so it must be an unchecked exception. Not sure of what we should do there. I can put in code to catch it, log an error, and thrown an InternalException, if that's the case. Is that what you think I should do? http://gerrit.cloudera.org:8080/#/c/21923/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java: http://gerrit.cloudera.org:8080/#/c/21923/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java@152 PS4, Line 152: // TODO: support explain plans > Remove TODO? Done -- To view, visit http://gerrit.cloudera.org:8080/21923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea6afaa1f1698a300ad047c8820691cf7e8eb44b Gerrit-Change-Number: 21923 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 21:06:50 +0000 Gerrit-HasComments: Yes
