Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21923 )
Change subject: IMPALA-13441: Support explain statements in Impala planner ...................................................................... Patch Set 5: Code-Review+2 (1 comment) This looks good to me, bumping to +2. I'll kick off a precommit job. http://gerrit.cloudera.org:8080/#/c/21923/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/21923/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@149 PS4, Line 149: if (Parser.parse(queryCtx.getStmt()) instanceof SelectStmt) { > Based on https://gerrit.cloudera.org/c/21989/, we can probably let it throw The regular parser would throw ParseException, which is a subclass of ImpalaException. So, it is fine to throw from here. A truly invalid statement (e.g. "select a a a a a") would get the error message from the Impala CUP parser rather than the error message from the Calcite parser. That doesn't sound like a problem. -- To view, visit http://gerrit.cloudera.org:8080/21923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea6afaa1f1698a300ad047c8820691cf7e8eb44b Gerrit-Change-Number: 21923 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2024 16:57:35 +0000 Gerrit-HasComments: Yes
