Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/benchmarks/parquet-delta-benchmark.cc File be/src/benchmarks/parquet-delta-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/benchmarks/parquet-delta-benchmark.cc@236 PS16, Line 236: move > clion says this should be std::move, here and below. The compiler doesn't have a problem with it, but I can go ahead and be specific. http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/rpc/thrift-thread.cc File be/src/rpc/thrift-thread.cc: http://gerrit.cloudera.org:8080/#/c/20494/16/be/src/rpc/thrift-thread.cc@86 PS16, Line 86: move > clion says this should be std::move. Maybe because there is no "using names It includes common/names.h. Maybe it's the _GLIBCXX_UTILITY guard that's causing problems. -- To view, visit http://gerrit.cloudera.org:8080/20494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Gerrit-Change-Number: 20494 Gerrit-PatchSet: 16 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 17:34:55 +0000 Gerrit-HasComments: Yes
