Hello Daniel Becker, Riza Suminto, gaurav singh, Joe McDonnell, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20494
to look at the new patch set (#18).
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param
......................................................................
IMPALA-12390 (part 4): Enable unnecessary-value-param
Enables the clang-tidy performance-unnecessary-value-param check and
fixes any issues found with run_clang_tidy.sh.
Updates based on how values are used:
- constructors and functions that take ownership of a value accept by
value and move into place to efficiently handle literal values
- others take a const& of the value
GetUsernameFromBasicAuthHeader was updated to make a copy closer to
where it's needed, rather than relying on the caller setting it up.
Updates CodegenNullPhiNode to use its 'name' parameter. Only impacts two
calls in filter-context.cc.
Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003
---
M .clang-tidy
M be/src/benchmarks/lock-benchmark.cc
M be/src/benchmarks/parquet-delta-benchmark.cc
M be/src/catalog/catalog-service-client-wrapper.h
M be/src/catalog/workload-management-init.cc
M be/src/codegen/codegen-anyval-read-write-info.cc
M be/src/codegen/codegen-anyval-read-write-info.h
M be/src/codegen/codegen-symbol-emitter.h
M be/src/codegen/llvm-codegen-cache-test.cc
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
M be/src/common/init.cc
M be/src/exec/avro/hdfs-avro-scanner-test.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/iceberg-buffered-delete-sink.cc
M be/src/exec/iceberg-buffered-delete-sink.h
M be/src/exec/json/json-parser.h
M be/src/exec/parquet/hdfs-parquet-scanner.h
M be/src/exec/parquet/hdfs-parquet-table-writer.cc
M be/src/exec/parquet/parquet-column-chunk-reader.cc
M be/src/exec/parquet/parquet-common-test.cc
M be/src/exec/parquet/parquet-delta-coder-test.cc
M be/src/exec/parquet/parquet-page-reader.h
M be/src/exec/scanner-context.h
M be/src/exprs/expr-test.cc
M be/src/rpc/TAcceptQueueServer.cpp
M be/src/rpc/TAcceptQueueServer.h
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr-test.h
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-thread.cc
M be/src/rpc/thrift-thread.h
M be/src/rpc/thrift-util.cc
M be/src/runtime/bufferpool/buffer-allocator.cc
M be/src/runtime/bufferpool/buffer-allocator.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/client-cache.cc
M be/src/runtime/client-cache.h
M be/src/runtime/exec-env.cc
M be/src/runtime/io/data-cache-trace-replayer.cc
M be/src/runtime/io/data-cache-trace-test.cc
M be/src/runtime/io/data-cache-trace.cc
M be/src/runtime/io/data-cache-trace.h
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/data-cache.h
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/io/disk-io-mgr.cc
M be/src/runtime/io/request-ranges.h
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/mem-tracker.cc
M be/src/runtime/multi-precision.h
M be/src/runtime/outbound-row-batch.h
M be/src/runtime/query-driver.cc
M be/src/runtime/query-driver.h
M be/src/runtime/reservation-manager.cc
M be/src/runtime/reservation-manager.h
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter.cc
M be/src/runtime/runtime-state.cc
M be/src/runtime/test-env.cc
M be/src/runtime/test-env.h
M be/src/runtime/thread-resource-mgr.cc
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tuple-cache-mgr-test.cc
M be/src/scheduling/admission-control-service.cc
M be/src/scheduling/admission-control-service.h
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/admissiond-env.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/executor-group.cc
M be/src/scheduling/hash-ring-test.cc
M be/src/scheduling/scheduler-test-util.cc
M be/src/scheduling/scheduler-test-util.h
M be/src/service/client-request-state.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/service/internal-server-test.cc
M be/src/service/query-state-record.cc
M be/src/service/query-state-record.h
M be/src/service/workload-management-worker.cc
M be/src/service/workload-management-worker.h
M be/src/statestore/statestore-service-client-wrapper.h
M be/src/statestore/statestore-subscriber-client-wrapper.h
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-subscriber.h
M be/src/statestore/statestore.h
M be/src/testutil/impalad-query-executor.h
M be/src/transport/THttpServer.cpp
M be/src/transport/THttpServer.h
M be/src/transport/THttpTransport.cpp
M be/src/transport/TSaslClientTransport.cpp
M be/src/transport/TSaslServerTransport.cpp
M be/src/transport/TSaslServerTransport.h
M be/src/transport/TSaslTransport.cpp
M be/src/util/bit-packing-test.cc
M be/src/util/bloom-filter-test.cc
M be/src/util/cache/lirs-cache.cc
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M be/src/util/decimal-util.h
M be/src/util/disk-info.cc
M be/src/util/disk-info.h
M be/src/util/in-list-filter-test.cc
M be/src/util/in-list-filter.cc
M be/src/util/in-list-filter.h
M be/src/util/internal-queue.h
M be/src/util/jwt-util-internal.h
M be/src/util/jwt-util.cc
M be/src/util/kudu-status-util.h
M be/src/util/logging-support-test.cc
M be/src/util/mpfit-util.cc
M be/src/util/network-util-test.cc
M be/src/util/os-util-test.cc
M be/src/util/parquet-reader.cc
M be/src/util/periodic-counter-updater.cc
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/simple-logger-test.cc
M be/src/util/simple-logger.cc
M be/src/util/simple-logger.h
M be/src/util/summary-util-test.cc
M be/src/util/symbols-util-test.cc
M be/src/util/thread.cc
M be/src/util/thread.h
M be/src/util/tuple-row-compare-test.cc
M be/src/workload_mgmt/workload-management.cc
M be/src/workload_mgmt/workload-management.h
134 files changed, 508 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/20494/18
--
To view, visit http://gerrit.cloudera.org:8080/20494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003
Gerrit-Change-Number: 20494
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com>
