Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22015 )
Change subject: IMPALA-13507: Allow disabling glog buffering via with_args fixture ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22015/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22015/1//COMMIT_MSG@20 PS1, Line 20: with '-logbuflevel=-1' for all daemons. If it is False, log WARNING on > I imagine most of the tests only check one daemon's log. But I don't see an Correct, I think it save to disable glog buffering in all daemons. Less thing to pay attention too if simply disable on all. http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/custom_cluster_test_suite.py@177 PS1, Line 177: if impalad_graceful_shutdown: > Why change this one but not reset_ranger? I did not see that at first. Will fix it in next patch set. http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/impala_test_suite.py@1370 PS1, Line 1370: LOG.warning("{} calls assert_log_contains(). Make sure that glog buffering has " > Does this essentially push us to move these to custom cluster tests? There are few EE tests that call this method. tests/metadata/test_ddl.py:1167: self.assert_impalad_log_contains('INFO', err) tests/observability/test_log_fragments.py:44: self.assert_impalad_log_contains('INFO', query_id + tests/observability/test_log_fragments.py:49: self.assert_impalad_log_contains('INFO', tests/observability/test_log_fragments.py:52: self.assert_impalad_log_contains('INFO', tests/observability/test_log_fragments.py:56: self.assert_impalad_log_contains('INFO', tests/webserver/test_web_pages.py:1162: self.assert_impalad_log_contains("INFO", "Cancelled from Impala\'s debug web " tests/webserver/test_web_pages.py:1171: self.assert_impalad_log_contains("INFO", "Session closed from Impala\'s debug " They're probably still require it until there are other ways to validate the same assertion without going to log files. -- To view, visit http://gerrit.cloudera.org:8080/22015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56fb1746b8f3cea9f3db3514a86a526dffb44a61 Gerrit-Change-Number: 22015 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2024 16:10:42 +0000 Gerrit-HasComments: Yes
