Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22015 )
Change subject: IMPALA-13507: Allow disabling glog buffering via with_args fixture ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/22015/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22015/1//COMMIT_MSG@20 PS1, Line 20: with '-logbuflevel=-1' for all daemons. If it is False, log WARNING on > Correct, I think it save to disable glog buffering in all daemons. Less thi Done http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/custom_cluster_test_suite.py@177 PS1, Line 177: if impalad_graceful_shutdown: > I did not see that at first. Will fix it in next patch set. Done http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/impala_test_suite.py@182 PS1, Line 182: # If True, call to assert_log_contains() will print WARN log for possibility of > typo: possibility Done http://gerrit.cloudera.org:8080/#/c/22015/1/tests/common/impala_test_suite.py@1370 PS1, Line 1370: LOG.warning( > There are few EE tests that call this method. Done -- To view, visit http://gerrit.cloudera.org:8080/22015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56fb1746b8f3cea9f3db3514a86a526dffb44a61 Gerrit-Change-Number: 22015 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2024 16:20:01 +0000 Gerrit-HasComments: Yes
