Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22010 )
Change subject: IMPALA-13502: Clean up around constructors ...................................................................... Patch Set 7: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22010/7/be/src/exec/tuple-file-writer.cc File be/src/exec/tuple-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/22010/7/be/src/exec/tuple-file-writer.cc@89 PS7, Line 89: RETURN_IF_ERROR(row_batch->Serialize(out_batch_.get(), /* compression_scratch */ nullptr)); line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4321888808a6b26f42664163e1d1fa137dbc7d14 Gerrit-Change-Number: 22010 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2024 22:47:45 +0000 Gerrit-HasComments: Yes
