Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22010 )
Change subject: IMPALA-13502: Clean up around constructors ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22010/4/be/src/exec/tuple-file-writer.cc File be/src/exec/tuple-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/22010/4/be/src/exec/tuple-file-writer.cc@83 PS4, Line 83: OutboundRowBatch out I think this OutboundRowBatch can also be reused? Note that RowBatch::Serialize calls output_batch->tuple_offsets_.clear() and output_batch->tuple_data_.resize(size). -- To view, visit http://gerrit.cloudera.org:8080/22010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4321888808a6b26f42664163e1d1fa137dbc7d14 Gerrit-Change-Number: 22010 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Nov 2024 22:22:08 +0000 Gerrit-HasComments: Yes
