Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22017 )
Change subject: IMPALA-9170 close idle connections without an associated session ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22017/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22017/1/be/src/service/impala-server.cc@2648 PS1, Line 2648: if (it == connection_to_sessions_map_.end()) return true; Joe had encountered this elsewhere and recommended using TCP keepalive (IMPALA-13253). Maybe this achieves the same thing? My reading would be that this patch results in TAcceptQueueServer (which checks for idle connections every idle_client_poll_period_s seconds) closing any connection that hasn't established a session. That might be too aggressive. -- To view, visit http://gerrit.cloudera.org:8080/22017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I359b0e0e90a7c6b32579234b1d88eb7ff27725d3 Gerrit-Change-Number: 22017 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2024 22:57:36 +0000 Gerrit-HasComments: Yes
